Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added link to binder repository (forked from @raybellwaves) #72

Merged
merged 2 commits into from
Nov 5, 2020

Conversation

nils-braun
Copy link
Collaborator

Additionally, added two notebooks.

@raybellwaves, I did as you mentioned on #60. I have forked your repo and have also included the notebooks here.
I took the chance to add also another notebook on custom functions and added some more documentation.

I am very happy you solved already the ecosystem-binder-stuff :-)

@nils-braun nils-braun mentioned this pull request Nov 4, 2020
2 tasks
@codecov-io
Copy link

codecov-io commented Nov 4, 2020

Codecov Report

Merging #72 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #72   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines         1296      1296           
  Branches       167       167           
=========================================
  Hits          1296      1296           
Impacted Files Coverage Δ
dask_sql/context.py 100.00% <0.00%> (ø)
dask_sql/server/app.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa85f16...8ad6f3b. Read the comment docs.

@raybellwaves
Copy link

Looks good. FYI Getting:

df = dask.datasets.timeseries().reset_index().persist()
c.create_table("timeseries", df)
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-2-4e51713202ef> in <module>
      2 
      3 df = dask.datasets.timeseries().reset_index().persist()
----> 4 c.create_table("timeseries", df)

AttributeError: 'Context' object has no attribute 'create_table'

on the second notebook. After you release following #63 it should work but then the syntax may have to be updated on the first notebook.

@nils-braun
Copy link
Collaborator Author

Thanks for checking!
I should have updated everything in sync.
I will have another look when I do the next release (which will be soon-ish).

@nils-braun nils-braun merged commit 05b08ae into main Nov 5, 2020
@nils-braun nils-braun deleted the feature/binder-link branch November 5, 2020 21:00
@raybellwaves raybellwaves mentioned this pull request Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants